linux-kernel - Re: [PATCH] kvm: selftests: add -std=gnu99 cflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <814c5c74-237a-ec69-c385-feec2d0a38f5@redhat.com>
Date:   Thu, 12 Apr 2018 18:36:04 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Peng Hao <peng.hao2@....com.cn>, shuah@...nel.org,
        hofsass@...gle.com
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: selftests: add -std=gnu99 cflags

On 13/04/2018 02:36, Peng Hao wrote:
> lib/kvm_util.c: In function ‘kvm_memcmp_hva_gva’:
> lib/kvm_util.c:332:2: error: ‘for’ loop initial declarations are only allowed in C99 mode
> 
> So add -std=gnu99 to CFLAGS
> 
> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
> ---
>  tools/testing/selftests/kvm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> index dc44de9..1da541e 100644
> --- a/tools/testing/selftests/kvm/Makefile
> +++ b/tools/testing/selftests/kvm/Makefile
> @@ -14,7 +14,7 @@ LIBKVM += $(LIBKVM_$(UNAME_M))
>  
>  INSTALL_HDR_PATH = $(top_srcdir)/usr
>  LINUX_HDR_PATH = $(INSTALL_HDR_PATH)/include/
> -CFLAGS += -O2 -g -I$(LINUX_HDR_PATH) -Iinclude -I$(<D)
> +CFLAGS += -O2 -g -std=gnu99 -I$(LINUX_HDR_PATH) -Iinclude -I$(<D)
>  
>  # After inclusion, $(OUTPUT) is defined and
>  # $(TEST_GEN_PROGS) starts with $(OUTPUT)/
> 

Queued, thanks.

Paolo