linux-kernel - Re: [GIT PULL] Thermal management updates for v4.17-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bbc5ab1-3532-95f5-1246-0bb89c566508@linaro.org>
Date:   Thu, 12 Apr 2018 19:42:09 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Zhang Rui <rui.zhang@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Eduardo Valentin <edubezval@...il.com>,
        "Li, Philip" <philip.li@...el.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [GIT PULL] Thermal management updates for v4.17-rc1

On 12/04/2018 18:55, Linus Torvalds wrote:
> On Wed, Apr 11, 2018 at 10:08 PM, Zhang Rui <rui.zhang@...el.com> wrote:
>>
>> could you please illustrate me what the kconfig & warning is?
> 
> Just "make allmodconfig" and the warning is about a uninitialized variable.
> 
> Line 304 in drivers/thermal/samsung/exynos_tmu.c if my shell history
> is to be believed.
> 
>                 Linus

These couple of warnings were introduced by:

commit 480b5bfc16e17ef51ca1c55bfcebf55db8673ebf
Author: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Date:   Tue Mar 6 15:43:45 2018 +0100

    thermal: exynos: remove parsing of samsung, tmu_default_temp_offset
property

    Trimming (one point based or two points based) is always used for
    the temperature calibration and the default non-trimming code should
    never be reached.

    Modify temp_to_code() and code_to_temp() accordingly (WARN_ON(1)
    in the default cases) and then remove no longer needed parsing of
    samsung,tmu_default_temp_offset property.

    There should be no functional changes caused by this patch.

    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
    Signed-off-by: Eduardo Valentin <edubezval@...il.com>


After digging into, there is no obvious fix. It returns effectively an
uninitialized value and the callers are assuming the value is always
correct, so it is also not possible to simply return an error.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog