linux-kernel - Re: [PATCH] rapidio: fix rio_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <933db59f-c28d-fb2c-9423-08828621de7a@gmail.com>
Date:   Thu, 12 Apr 2018 14:47:49 -0400
From:   Alexandre Bounine <alex.bou9@...il.com>
To:     Ioan Nicu <ioan.nicu.ext@...ia.com>,
        Barry Wood <barry.wood@....com>,
        Matt Porter <mporter@...nel.crashing.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Al Viro <viro@...iv.linux.org.uk>,
        Logan Gunthorpe <logang@...tatee.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Frank Kunz <frank.kunz@...ia.com>,
        Alexander Sverdlin <alexander.sverdlin@...ia.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rapidio: fix rio_dma_transfer error handling

On 2018-04-12 11:06 AM, Ioan Nicu wrote:
> Some of the mport_dma_req structure members were initialized late
> inside the do_dma_request() function, just before submitting the
> request to the dma engine. But we have some error branches before
> that. In case of such an error, the code would return on the error
> path and trigger the calling of dma_req_free() with a req structure
> which is not completely initialized. This causes a NULL pointer
> dereference in dma_req_free().
> 
> This patch fixes these error branches by making sure that all
> necessary mport_dma_req structure members are initialized in
> rio_dma_transfer() immediately after the request structure gets
> allocated.
> 
> Signed-off-by: Ioan Nicu <ioan.nicu.ext@...ia.com>
> ---
>   drivers/rapidio/devices/rio_mport_cdev.c | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
> 
Acked-by: Alexandre Bounine <alex.bou9@...il.com>