linux-kernel - Re: [PATCH v2] block: ratelimite pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1y3hsunnt.fsf@oracle.com>
Date:   Thu, 12 Apr 2018 17:20:54 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Jack Wang <jinpu.wang@...fitbricks.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, elliott@....com
Subject: Re: [PATCH v2] block: ratelimite pr_err on IO path


Jack,

> +				pr_err_ratelimited("%s: ref tag error at location %llu (rcvd %u)\n",

I'm a bit concerned about dropping records of potential data loss.

Also, what are you doing that compels all these to be logged? This
should be a very rare occurrence.

-- 
Martin K. Petersen	Oracle Linux Engineering