linux-kernel - Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180412230456.GA21454@gfm-ubuntu>
Date:   Thu, 12 Apr 2018 20:04:56 -0300
From:   Gabriel Francisco Mandaji <gfmandaji@...il.com>
To:     Ian Abbott <abbotti@....co.uk>
Cc:     gregkh@...uxfoundation.org, hsweeten@...ionengravers.com,
        julia.lawall@...6.fr, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: fix alignment of function
 parameters

On Wed, Apr 11, 2018 at 10:18:38AM +0100, Ian Abbott wrote:
> On 10/04/18 23:50, Gabriel Francisco Mandaji wrote:
> >Fix most checkpatch.pl issues of type:
> >
> >CHECK: Alignment should match open parenthesis
> >---
> Looks good, thanks.  I guess the remaining case of open parentheses
> alignment wasn't changed because that would exceed 80 columns.

Exactly. I wasn't sure whether it would be OK to use a temporary variable
to store the longest parameter on that line (devpriv->ai_buffer[devpriv->ai_dma_index]),
so I ended up fixing only the straightforward occurrences.

Thanks!