linux-kernel - Re: [PATCH v2] vfio: platform: Make printed error messages more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1468eeb-83a9-8537-5d72-f56c19b85858@redhat.com>
Date:   Fri, 13 Apr 2018 10:54:57 +0200
From:   Auger Eric <eric.auger@...hat.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Baptiste Reynal <b.reynal@...tualopensystems.com>,
        Alex Williamson <alex.williamson@...hat.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] vfio: platform: Make printed error messages more
 consistent

Hi Geert,On 10/04/18 16:54, Geert Uytterhoeven wrote:
>   - Capitalize the first word of error messages,
>   - Unwrap statements that fit on a single line,
>   - Use "VFIO" instead of "vfio" as the error message prefix.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reviewed-by: Eric Auger <eric.auger@...hat.com>
Acked-by: Eric Auger <eric.auger@...hat.com>

Thanks

Eric
> ---
> v2:
>   - Add Reviewed-by.
> ---
>  drivers/vfio/platform/vfio_platform_common.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 4c27f4be3c3d0385..35469af87f88678e 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -630,8 +630,7 @@ static int vfio_platform_of_probe(struct vfio_platform_device *vdev,
>  	ret = device_property_read_string(dev, "compatible",
>  					  &vdev->compat);
>  	if (ret)
> -		pr_err("VFIO: cannot retrieve compat for %s\n",
> -			vdev->name);
> +		pr_err("VFIO: Cannot retrieve compat for %s\n", vdev->name);
>  
>  	return ret;
>  }
> @@ -673,7 +672,7 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
>  
>  	ret = vfio_platform_get_reset(vdev);
>  	if (ret && vdev->reset_required) {
> -		pr_err("vfio: no reset function found for device %s\n",
> +		pr_err("VFIO: No reset function found for device %s\n",
>  		       vdev->name);
>  		return ret;
>  	}
>