linux-kernel - Re: [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180413120958.vo4y34q36q2rjyej@flea>
Date:   Fri, 13 Apr 2018 14:09:58 +0200
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Jagan Teki <jagannadh.teki@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        dri-devel@...ts.freedesktop.org,
        Gustavo Padovan <gustavo@...ovan.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 0/8] drm/sun4i: Allwinner MIPI-DSI support

On Fri, Apr 13, 2018 at 05:30:04PM +0530, Jagan Teki wrote:
> On Wed, Apr 11, 2018 at 6:13 PM, Maxime Ripard
> <maxime.ripard@...tlin.com> wrote:
> > On Wed, Apr 04, 2018 at 11:57:08AM +0200, Maxime Ripard wrote:
> >> Hi,
> >>
> >> Here is an preliminary version of the MIPI-DSI support for the Allwinner
> >> SoCs.
> >>
> >> This controller can be found on a number of recent SoCs, such as the
> >> A31, A33 or the A64.
> >>
> >> Given the sparse documentation, there's a number of obscure areas, but
> >> the current implementation has been tested with a 4-lanes DSI panel on
> >> an A33.
> >>
> >> The support is a bit rough around the edges at the time, and some artifacts
> >> are still shown on the screen for some reasons. Wider testing with
> >> different display will hopefully nail those down.
> >>
> >> This needs the regmap_mmio_attach_clk, on its way to Linus in 4.17.
> >>
> >> Let me know what you think,
> >> Maxime
> >>
> >> Changes from v3:
> >>   - Rebased on top of current drm-misc-next
> >>   - Switched to SPDX license header
> >>   - Made the ECC array const
> >>   - Split the big DSI patch into two, one to add the DSI driver and one to
> >>     add the TCON bits.
> >>   - Removed the dithering code
> >>   - Changed the DT labels to remove the indices
> >>   - Used sleeps instead of delays in the panel driver
> >>   - Used the backlight_enable / _disable functions
> >>   - Added Chen-Yu's Reviewed-by
> >>
> >> Changes from v2:
> >>   - Added a ports node under the DSI node
> >>   - Changed the huarui panel driver to an ili9881c driver
> >>   - Changed the panel vendor to bananapi
> >>   - Made the init table static in the panel driver
> >>   - Dropped the huarui vendor patch for the DT doc.
> >>
> >> Changes from v1:
> >>   - Rebased on 4.16-rc1
> >>   - Constified a few function arguments and structures
> >>   - Reworked the DT binding example a bit
> >>   - Reworked the panel driver to check for DSI return codes, and use DCS
> >>     helpers when possible
> >>
> >> Maxime Ripard (8):
> >>   drm/sun4i: tcon: Add TRI finish interrupt for vblank
> >>   dt-bindings: display: Add Allwinner MIPI-DSI bindings
> >>   drm/sun4i: Add Allwinner A31 MIPI-DSI controller support
> >>   drm/sun4i: Tie the DSI controller in the TCON
> >>   dt-bindings: panel: Add the Ilitek ILI9881c panel documentation
> >>   drm/panel: Add Ilitek ILI9881c panel driver
> >>   ARM: dts: sun8i: a33: Add the DSI-related nodes
> >>   [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display
> 
> I have reviewed most of the patches and reused for A64 all look fine
> to me (except the panel driver). May be my issue is not relevant to
> this thread, but I'm looking for help If I miss anything for A64 [1]
> and [2] are changes made for A64, the issue is kernel hang while
> loading sun6i_dsi.

My guess would be that you're not claiming the DE2 SRAM. See:
https://lkml.org/lkml/2018/3/16/1096

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)