linux-kernel - Re: [PATCH] staging fbtft: Fixed lines exceeding columns limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180413125747.ccynu6twioa22fee@mwanda>
Date:   Fri, 13 Apr 2018 15:57:47 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Renato Soma <renatoys08@...il.com>
Cc:     thomas.petazzoni@...e-electrons.com, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, lkcamp@...ts.libreplanetbr.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging fbtft: Fixed lines exceeding columns limit

>  	if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) {                    \
>  		va_start(args, len);                                          \
>  		for (i = 0; i < len; i++) {                                   \
> -			buf[i] = modifier((data_type)va_arg(args, unsigned int)); \
> +			buf[i] = modifier((data_type)va_arg(args,             \
> +						unsigned int));               \


Normally we'd align the parameters like so:

			buf[i] = modifier((data_type)va_arg(args,		\
							    unsigned int));	\



>  		}                                                             \
>  		va_end(args);                                                 \
> -		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, buffer_type, buf, len, "%s: ", __func__); \
> +		fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par,                  \
> +				par->info->device, buffer_type,               \
> +				buf, len, "%s: ", __func__);                  \
>  	}                                                                     \

Not properly aligned.


>  									      \
>  	va_start(args, len);                                                  \
> @@ -37,7 +40,8 @@ void func(struct fbtft_par *par, int len, ...)                                \
>  	}                                                                     \
>  									      \
>  	*buf = modifier((data_type)va_arg(args, unsigned int));               \
> -	ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, 0); \

I feel like the original is basically OK but if we're going to change it
then align it like this:

	ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset,	\
				 0);						\


Etc.

regards,
dan carpenter