linux-kernel - Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89591f43-19c6-26b5-c0f7-e370721ec397@oracle.com>
Date:   Fri, 13 Apr 2018 09:19:07 -0600
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     ssantosh@...nel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats
 counter

On 4/11/18 3:28 PM, santosh.shilimkar@...cle.com wrote:
> On 4/11/18 12:16 PM, Vasyl Gomonovych wrote:
>> Hwqueue has collect statistics in heavy use queue_pop/queu_push functions
>> for cache efficiency and make push/pop faster use percpu variables.
>> For performance reasons, driver should keep descriptor in software 
>> handler
>> as short as possible and quickly return it back to hardware queue.
>> Descriptors coming into driver from hardware after pop and return back
>> by push to reduce descriptor lifetime in driver collect statistics on 
>> percpu.
>>
>> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
>> ---
> This is really good idea. Have you tested this patch ? If not it needs
> to be tested on Keystone SOCs to make sure all works.
> 
Thanks for confirming the tests done with rapidIO offlist. Will queue
this patch for next merge window.

Regards,
Santosh