linux-kernel - Re: [PATCH v2 0/2] tracing/events: block: bring more on a par with blktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180413135029.05163827@gandalf.local.home>
Date:   Fri, 13 Apr 2018 13:50:29 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Steffen Maier <maier@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Li Zefan <lizefan@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2 0/2] tracing/events: block: bring more on a par with
 blktrace

On Fri, 13 Apr 2018 18:36:20 +0200
Steffen Maier <maier@...ux.ibm.com> wrote:

> I had the need to understand I/O request processing in detail.
> But I also had the need to enrich block traces with other trace events
> including my own dynamic kprobe events. So I preferred block trace events
> over blktrace to get everything nicely sorted into one ftrace output.
> However, I missed device filtering for (un)plug events and also
> the difference between the two flavors of unplug.
> 
> The first two patches bring block trace events closer to their
> counterpart in blktrace tooling.
> 
> The last patch is just an RFC. I still kept it in this patch set because
> it is inspired by PATCH 2/2.
> 
> Changes since v1:
> [PATCH v2 1/2]
> Use 0 and 1 instead of false and true for __print_symbolic table.
> Now "trace-cmd report" can decode it. [Steven Rostedt]
> 
> Steffen Maier (3):
>   tracing/events: block: track and print if unplug was explicit or
>     schedule
>   tracing/events: block: dev_t via driver core for plug and unplug
>     events
>   tracing/events: block: also try to get dev_t via driver core for some
>     events
> 
>  include/trace/events/block.h | 33 ++++++++++++++++++++++++++++-----
>  1 file changed, 28 insertions(+), 5 deletions(-)
> 

>From just the tracing point of view:

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

as for the race conditions in the block layer, I'll let someone else
decided that.

-- Steve