linux-kernel - Re: [PATCH] fs: avoid fdput() after failed fdget() in vfs_dedupe_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180414075544.GU30522@ZenIV.linux.org.uk>
Date:   Sat, 14 Apr 2018 08:55:45 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Zev Weiss <zev@...ilderbeest.net>
Cc:     "Darrick J . Wong" <darrick.wong@...cle.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: avoid fdput() after failed fdget() in
 vfs_dedupe_file_range()

On Sat, Apr 14, 2018 at 01:16:58AM -0500, Zev Weiss wrote:
> It's a fairly inconsequential bug, since fdput() won't actually try to
> fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in
> the failure case, but most other vfs code takes steps to avoid this.

Applied.