lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180414011158.GC18392@ssaleem-MOBL4.amr.corp.intel.com> Date: Fri, 13 Apr 2018 20:11:58 -0500 From: Shiraz Saleem <shiraz.saleem@...el.com> To: Jia-Ju Bai <baijiaju1990@...il.com> Cc: faisal.latif@...el.com, dledford@...hat.com, sean.hefty@...el.com, hal.rosenstock@...il.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2param_change On Wed, Apr 11, 2018 at 03:33:06PM +0800, Jia-Ju Bai wrote: > i40iw_l2param_change() is never called in atomic context. > > i40iw_make_listen_node() is only set as ".l2_param_change" > in struct i40e_client_ops, and this function pointer is not called > in atomic context. > > Despite never getting called from atomic context, > i40iw_l2param_change() calls kzalloc() with GFP_ATOMIC, > which does not sleep for allocation. > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, > which can sleep and improve the possibility of sucessful allocation. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com> > --- > Acked-by: Shiraz Saleem <shiraz.saleem@...el.com>
Powered by blists - more mailing lists