linux-kernel - Re: [PATCH v3 4/7] iio:dac:ad5686: Add support for AD5685R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 15 Apr 2018 19:20:56 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     <Michael.Hennerich@...log.com>, <lars@...afoo.de>,
        <knaack.h@....de>, <pmeerw@...erw.net>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/7] iio:dac:ad5686: Add support for AD5685R

On Wed, 11 Apr 2018 14:52:48 +0300
Stefan Popa <stefan.popa@...log.com> wrote:

> This driver acctually supports the AD5685R device and NOT the AD5685, which
> does not exist.
> 
> More information can be found in the datasheet:
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5686_5684.pdf
> 
> Signed-off-by: Stefan Popa <stefan.popa@...log.com>
Hmm. Problem here is if there are devicetrees out there using the wrong name.
We can't be sure there aren't. So right option is to keep both in the id table.

I've modified the patch to include the wrong name with a note saying it
doesn't actually exist.

Hope that is fine with you

Thanks,

Jonathan

> ---
> Changes in v2:
> 	- Refactored the patch to add support for new parts
> Changes in v3:
> 	- Nothing changed, just to follow the patch set version.
> 
>  drivers/iio/dac/ad5686.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 87d6e6e..a753ffd 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -88,7 +88,7 @@ struct ad5686_state {
>  
>  enum ad5686_supported_device_ids {
>  	ID_AD5684,
> -	ID_AD5685,
> +	ID_AD5685R,
>  	ID_AD5686,
>  };
>  static int ad5686_spi_write(struct ad5686_state *st,
> @@ -303,7 +303,7 @@ static const struct ad5686_chip_info ad5686_chip_info_tbl[] = {
>  		.num_channels = 4,
>  		.int_vref_mv = 2500,
>  	},
> -	[ID_AD5685] = {
> +	[ID_AD5685R] = {
>  		.channels = ad5685r_channels,
>  		.int_vref_mv = 2500,
>  		.num_channels = 4,
> @@ -392,7 +392,7 @@ static int ad5686_remove(struct spi_device *spi)
>  
>  static const struct spi_device_id ad5686_id[] = {
>  	{"ad5684", ID_AD5684},
> -	{"ad5685", ID_AD5685},
> +	{"ad5685r", ID_AD5685R},
>  	{"ad5686", ID_AD5686},
>  	{}
>  };