lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180415150108.1341-3-hch@lst.de> Date: Sun, 15 Apr 2018 17:01:03 +0200 From: Christoph Hellwig <hch@....de> To: viro@...iv.linux.org.uk Cc: Avi Kivity <avi@...lladb.com>, linux-aio@...ck.org, linux-fsdevel@...r.kernel.org, linux-api@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 2/7] aio: remove an outdated BUG_ON and comment in aio_complete These days we don't treat sync iocbs special in the aio completion code as they never use it. Remove the old comment and BUG_ON given that the current definition of is_sync_kiocb makes it impossible to hit. Signed-off-by: Christoph Hellwig <hch@....de> --- fs/aio.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index add46b06be86..7c1855afd723 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1107,15 +1107,6 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2) file_end_write(file); } - /* - * Special case handling for sync iocbs: - * - events go directly into the iocb for fast handling - * - the sync task with the iocb in its stack holds the single iocb - * ref, no other paths have a way to get another ref - * - the sync task helpfully left a reference to itself in the iocb - */ - BUG_ON(is_sync_kiocb(kiocb)); - if (iocb->ki_list.next) { unsigned long flags; -- 2.17.0
Powered by blists - more mailing lists