linux-kernel - Re: [PATCH v3] mm/page_owner: ignore everything below the IRQ entry point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180416054459epcms5p85f343635408abccfd12080d7fc322911@epcms5p8>
Date:   Mon, 16 Apr 2018 11:14:59 +0530
From:   Maninder Singh <maninder1.s@...sung.com>
To:     "dvyukov@...gle.com" <dvyukov@...gle.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "vbabka@...e.cz" <vbabka@...e.cz>, "arnd@...db.de" <arnd@...db.de>
CC:     kbuild test robot <lkp@...el.com>,
        "kbuild-all@...org" <kbuild-all@...org>,
        "aryabinin@...tuozzo.com" <aryabinin@...tuozzo.com>,
        "glider@...gle.com" <glider@...gle.com>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "vinmenon@...eaurora.org" <vinmenon@...eaurora.org>,
        "gomonovych@...il.com" <gomonovych@...il.com>,
        Ayush Mittal <ayush.m@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        AMIT SAHRAWAT <a.sahrawat@...sung.com>,
        PANKAJ MISHRA <pankaj.m@...sung.com>,
        Vaneet Narang <v.narang@...sung.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "jdike@...toit.com" <jdike@...toit.com>,
        "richard@....at" <richard@....at>,
        "user-mode-linux-devel@...ts.sourceforge.net" 
        <user-mode-linux-devel@...ts.sourceforge.net>,
        "user-mode-linux-user@...ts.sourceforge.net" 
        <user-mode-linux-user@...ts.sourceforge.net>
Subject: Re: [PATCH v3] mm/page_owner: ignore everything below the IRQ entry
 point

 
Hi Arnd,


We sent one patch for ignoring entries below IRQ point in page_onwer using stackdepot.

V2:- https://lkml.org/lkml/2018/3/26/178

V3:- https://lkml.org/lkml/2018/3/27/357

But it's breaking build for um target with below reason.


   kernel/stacktrace.o: In function `filter_irq_stacks':
>> stacktrace.c:(.text+0x20e): undefined reference to `__irqentry_text_start'
>> stacktrace.c:(.text+0x218): undefined reference to `__irqentry_text_end'
>> stacktrace.c:(.text+0x222): undefined reference to `__softirqentry_text_start'
>> stacktrace.c:(.text+0x22c): undefined reference to `__softirqentry_text_end'
   collect2: error: ld returned 1 exit status

So can we add below fix for this build break, can you suggest if it is ok or we need to find
some other way:-

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 76b63f5..0f3b7f8 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -460,6 +460,10 @@
  * to use ".." first.
  */
 #define TEXT_TEXT                                                      \
+               VMLINUX_SYMBOL(__irqentry_text_start) = .;              \
+               VMLINUX_SYMBOL(__irqentry_text_end) = .;                \
+               VMLINUX_SYMBOL(__softirqentry_text_start) = .;          \
+               VMLINUX_SYMBOL(__softirqentry_text_end) = .;            \
                ALIGN_FUNCTION();                                       \
                *(.text.hot TEXT_MAIN .text.fixup .text.unlikely)       \
                *(.text..refcount)                                      \
diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h


To make solution generic for all architecture we declared 4 dummy variables which we used in our patch.


Thanks ,
Maninder Singh