linux-kernel - Re: [PATCH 1/2] tty: n_gsm: Fix long delays with control frame timeouts in ADM mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180416084439.GA5489@amd>
Date:   Mon, 16 Apr 2018 10:44:39 +0200
From:   Pavel Machek <pavel@....cz>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Alan Cox <alan@...yncelyn.cymru>,
        Dan Williams <dcbw@...hat.com>,
        Jiri Prchal <jiri.prchal@...ignal.cz>,
        Jiri Slaby <jslaby@...e.cz>, Marcel Partap <mpartap@....net>,
        Merlijn Wajer <merlijn@...zup.org>,
        Michael Nazzareno Trimarchi <michael@...rulasolutions.com>,
        Michael Scott <michael.scott@...aro.org>,
        Peter Hurley <peter@...leysoftware.com>,
        Russ Gorby <russ.gorby@...el.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH 1/2] tty: n_gsm: Fix long delays with control frame
 timeouts in ADM mode


> Do you have phy-mapphone-mdm6600 loaded? That is still needed to
> configure all the boot mode pins for the modem so it is usable..
> The UART will then work also without ohci-platform, just the
> USB PHY is disabled without ohci-platform.
> 
> I have these in my .config:
> CONFIG_SERIAL_8250_OMAP=y
> CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y
> CONFIG_PHY_MAPPHONE_MDM6600=m
> CONFIG_N_GSM=m
> 
> And then the two patches from $subject thread. I just tried
> it with today's mainline kernel and it's still working for
> me.
> 
> Maybe you're missing some related patch though if usingv4.16?
> 
> 984c7706ff18 ("ARM: dts: omap4-droid4: Configure uart1 pins")
> e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY")
> fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming")
> bca809d8183c ("ARM: omap2plus_defconfig: Enable MDM6600 USB PHY")
> 077e1cde78c3 ("ARM: omap2plus_defconfig: Enable 8250_OMAP"
> 
> So maybe you're still using CONFIG_SERIAL_OMAP=y instead of
> CONFIG_SERIAL_8250_OMAP=y?

Ahha, so first I missed two of the patches, and second, I was not
patient enough. I was stopping my test after first or second
error. Now I get... so I guess it works for me.

Thanks!

For the series:

Tested-by: Pavel Machek <pavel@....cz>

								Pavel

user@...uan:/my/droid4-ngsm$ sudo ./droid4-ngsm
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
Could not open /dev/gsmtty1: Level 2 halted
Trying to start ngsm again: Level 2 halted
Starting ngsm..
Testing ngsm..
1> U0000AT+CFUN?
1<
Enable speaker phone..
2> U0001AT+EACC=3,0
2<
2> U0002AT+CMUT=0
2<
2> U0003AT+NREC=1
2<
2> U0004AT+CLVL=6
2<
Started ngsm, press Ctrl-C to exit when done



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)