linux-kernel - Re: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180416093821.sqrcc6mmnc23njul@dell>
Date:   Mon, 16 Apr 2018 10:38:21 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Daniel Schultz <d.schultz@...tec.de>
Cc:     zyw@...k-chips.com, zhangqing@...k-chips.com, xsf@...k-chips.com,
        tony.xie@...k-chips.com, w.egorov@...tec.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions

On Thu, 29 Mar 2018, Daniel Schultz wrote:

> Since all three shutdown functions have almost the same code, all logic
> from the shutdown functions can be refactored to a new function
> "rk808_update_bits", which can update a register by a given address and
> bitmask.
> 
> Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
> ---
> Changes:
> 	v2: Re-submit with recipients from Rockchip.
> 	v3: - Added devicetree property to enable the PMIC reset seperate from 
> 	      "rockchip,system-power-controller".
> 	    - Dropped the first patch of this serie.
> 	v4: Splitted refactoring and the new reset feature.
> 	v5: Removed null pointer from rk808_update_bits.
> 
>  drivers/mfd/rk808.c | 46 +++++++++++++---------------------------------
>  1 file changed, 13 insertions(+), 33 deletions(-)

I'd still like an Ack/Review from the Rockchip guys please.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog