linux-kernel - Re: [PATCH v2 03/12] X86/nVMX: Update the PML table without mapping and unmapping the page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dc50744-9cb1-08ea-098b-d991e7e2ce70@redhat.com>
Date:   Mon, 16 Apr 2018 13:10:56 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     KarimAllah Ahmed <karahmed@...zon.de>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        rkrcmar@...hat.com
Subject: Re: [PATCH v2 03/12] X86/nVMX: Update the PML table without mapping
 and unmapping the page

On 15/04/2018 23:53, KarimAllah Ahmed wrote:
> +		dst = vmcs12->pml_address + sizeof(u64) * vmcs12->guest_pml_index;
>  
> -		page = kvm_vcpu_gpa_to_page(vcpu, vmcs12->pml_address);
> -		if (is_error_page(page))
> +		if (kvm_write_guest_page(vcpu->kvm, gpa_to_gfn(dst), &gpa,
> +					 offset_in_page(dst), sizeof(gpa)))

If you want to use kvm_write_guest_page, this can also be

		if (kvm_write_guest_page(vcpu->kvm,
					 gpa_to_gfn(vmcs12->pml_address), &gpa,
					 sizeof(gpa) * vmcs12->guest_pml_index,
					 sizeof(gpa)))

(I should have been more verbose on _why_ I suggested that function; my bad).

Paolo