linux-kernel - RE: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings

Open Source and information security mailing list archives

Date:   Mon, 16 Apr 2018 12:30:08 +0000
From:   "Li, Philip" <philip.li@...el.com>
To:     Daniel Vetter <daniel@...ll.ch>,
        Julia Lawall <julia.lawall@...6.fr>
CC:     "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "David Airlie" <airlied@...ux.ie>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Andrew Jeffery <andrew@...id.au>,
        "Joel Stanley" <joel@....id.au>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kbuild-all@...org" <kbuild-all@...org>
Subject: RE: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings

> Subject: Re: [kbuild-all] [PATCH] drm: fix drm-get-put.cocci warnings
> 
> On Thu, Apr 12, 2018 at 07:54:10AM +0200, Julia Lawall wrote:
> > From: Fengguang Wu <fengguang.wu@...el.com>
> >
> >  Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and
> >  drm_*_unreference() helpers.
> >
> > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> >
> > Fixes: 6784ac15bc68 ("drm: Add ASPEED GFX driver")
> > Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> > ---
> >
> > tree:   https://github.com/shenki/linux drm-v1
> 
> This isn't an upstream tree (and the aspeed driver isn't in upstream
> afaict), so no need for spamming mailing lists I think.
thanks for feedback Daniel, we will mark this repo as private one to avoid
reporting to larger mailing list.

> 
> But thanks for doing all this, great motivation to put more of the drm
> refactorings into cocci files.
> 
> Cheers, Daniel
> > head:   9680ed7979d5d403c6bde36271a048d62c048180
> > commit: 6784ac15bc6889280522b04b97f1fb1208ee45e7 [23/27] drm: Add
> ASPEED
> > GFX
> > driver
> >
> >  aspeed_gfx_drv.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
> > @@ -268,7 +268,7 @@ static int aspeed_gfx_probe(struct platf
> >  err_unload:
> >  	aspeed_gfx_unload(drm);
> >  err_free:
> > -	drm_dev_unref(drm);
> > +	drm_dev_put(drm);
> >
> >  	return ret;
> >  }
> > @@ -279,7 +279,7 @@ static int aspeed_gfx_remove(struct plat
> >
> >  	drm_dev_unregister(drm);
> >  	aspeed_gfx_unload(drm);
> > -	drm_dev_unref(drm);
> > +	drm_dev_put(drm);
> >
> >  	return 0;
> >  }
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@...ts.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives