linux-kernel - Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAFQd5C_RhqSCfEXNPQ0zH-O1PGk6xGEdvzsSxnfz9kJ5G4Ceg@mail.gmail.com>
Date:   Mon, 16 Apr 2018 13:12:07 +0000
From:   Tomasz Figa <tfiga@...omium.org>
To:     a.hajda@...sung.com
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Archit Taneja <architt@...eaurora.org>,
        Inki Dae <inki.dae@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sandy Huang <hjc@...k-chips.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        Heiko Stübner <heiko@...ech.de>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Douglas Anderson <dianders@...omium.org>,
        Yakir Yang <ykk@...k-chips.com>, kernel@...labora.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
        jy0922.shim@...sung.com, rydberg@...math.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        kgene@...nel.org, linux-input@...r.kernel.org,
        Ørjan Eide <orjan.eide@....com>,
        Caesar Wang <wxt@...k-chips.com>,
        Jeffy <jeffy.chen@...k-chips.com>,
        "list@....net:IOMMU DRIVERS <iommu@...ts.linux-foundation.org>, Joerg
        Roedel <joro@...tes.org>," <linux-arm-kernel@...ts.infradead.org>,
        Mark yao <mark.yao@...k-chips.com>,
        王征增 <wzz@...k-chips.com>,
        Lin Huang <hl@...k-chips.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        kuankuan.y@...il.com, Haixia Shi <hshi@...omium.org>
Subject: Re: [PATCH v6 28/30] drm/rockchip: Disable PSR from reboot notifier

Hi Andrzej,

On Mon, Apr 16, 2018 at 6:57 PM Andrzej Hajda <a.hajda@...sung.com> wrote:

> On 05.04.2018 11:49, Enric Balletbo i Serra wrote:
> > From: Tomasz Figa <tfiga@...omium.org>
> >
> > It looks like the driver subsystem detaches devices from power domains
> > at shutdown without consent of the drivers.

> It looks bit strange. Could you elaborate more on it. Could you show the
> code performing the detach?

It not only looks strange, but it is strange. The code was present in 4.4:

https://elixir.bootlin.com/linux/v4.4.128/source/drivers/base/platform.c#L553

but was apparently removed in 4.5:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/base/platform.c?h=next-20180416&id=2d30bb0b3889adf09b342722b2ce596c0763bc93

So we might not need this patch anymore.

Best regards,
Tomasz