linux-kernel - Re: [PATCHv4 04/10] mfd: ti-lmu: drop of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180416144046.zf4iaedm7nkymstn@dell>
Date:   Mon, 16 Apr 2018 15:40:46 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Cc:     Sebastian Reichel <sre@...nel.org>, Milo Kim <Milo.Kim@...com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCHv4 04/10] mfd: ti-lmu: drop of_compatible for backlight
 driver

On Fri, 30 Mar 2018, Sebastian Reichel wrote:

> This removes the of_compatible for the backlight sub-device. There
> will be no extra sub-node for the backlight.

Won't doing this in a separate patch break bisectability?

> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
> ---
>  drivers/mfd/ti-lmu.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/mfd/ti-lmu.c b/drivers/mfd/ti-lmu.c
> index 2ee09d099832..de76298cf3a8 100644
> --- a/drivers/mfd/ti-lmu.c
> +++ b/drivers/mfd/ti-lmu.c
> @@ -58,7 +58,6 @@ static const struct mfd_cell lm3532_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3532,
> -		.of_compatible = "ti,lm3532-backlight",
>  	},
>  };
>  
> @@ -78,7 +77,6 @@ static const struct mfd_cell lm3631_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3631,
> -		.of_compatible = "ti,lm3631-backlight",
>  	},
>  };
>  
> @@ -89,7 +87,6 @@ static const struct mfd_cell lm3632_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3632,
> -		.of_compatible = "ti,lm3632-backlight",
>  	},
>  };
>  
> @@ -97,7 +94,6 @@ static const struct mfd_cell lm3633_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3633,
> -		.of_compatible = "ti,lm3633-backlight",
>  	},
>  	{
>  		.name          = "lm3633-leds",
> @@ -115,7 +111,6 @@ static const struct mfd_cell lm3695_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3695,
> -		.of_compatible = "ti,lm3695-backlight",
>  	},
>  };
>  
> @@ -123,7 +118,6 @@ static const struct mfd_cell lm3697_devices[] = {
>  	{
>  		.name          = "ti-lmu-backlight",
>  		.id            = LM3697,
> -		.of_compatible = "ti,lm3697-backlight",
>  	},
>  	/* Monitoring driver for open/short circuit detection */
>  	{

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog