linux-kernel - Re: [PATCH] x86/ldt: Fix support_pte_mask filtering in map_ldt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07e2c23e-10b7-b03f-5706-3d4b910537ba@linux.intel.com>
Date:   Mon, 16 Apr 2018 08:39:37 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Andy Lutomirski <luto@...nel.org>, Joerg Roedel <joro@...tes.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...e.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH] x86/ldt: Fix support_pte_mask filtering in
 map_ldt_struct()

On 04/16/2018 08:16 AM, Andy Lutomirski wrote:
> On Mon, Apr 16, 2018 at 2:43 AM, Joerg Roedel <joro@...tes.org> wrote:
>> From: Joerg Roedel <jroedel@...e.de>
>>
>> The |= operator will let us end up with an invalid PTE. Use
>> the correct &= instead.
> D'oh!  Looks good.

Yes, agreed.  Thanks for finding that, Joerg!