linux-kernel - Re: [PATCH v4 2/3] ASoC: topology: Add missing clock gating parameter when parsing hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Apr 2018 17:52:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Kirill Marinushkin <k.marinushkin@...il.com>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
        Pan Xiuli <xiuli.pan@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v4 2/3] ASoC: topology: Add missing clock gating
 parameter when parsing hw_configs

On Wed, Apr 04, 2018 at 06:19:38AM +0200, Kirill Marinushkin wrote:

> +		/* clock gating */
> +		if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED)
> +			link->dai_fmt |= SND_SOC_DAIFMT_GATED;
> +		else if (hw_config->clock_gated ==
> +			 SND_SOC_TPLG_DAI_CLK_GATE_CONT)
> +			link->dai_fmt |= SND_SOC_DAIFMT_CONT;

I'll apply this but the above would be better written as a switch
statement - could you please send an incremental patch changing it?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)