lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Apr 2018 20:43:39 +0000 From: Bart Van Assche <Bart.VanAssche@....com> To: "beanhuo@...ron.com" <beanhuo@...ron.com>, "rostedt@...dmis.org" <rostedt@...dmis.org>, "rajatja@...gle.com" <rajatja@...gle.com> CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "mingo@...had.com" <mingo@...had.com>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "axboe@...nel.dk" <axboe@...nel.dk>, "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com> Subject: Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events On Mon, 2018-04-16 at 20:27 +0000, Bean Huo (beanhuo) wrote: > By the way, these patches are not to add new feature, they are just to > add print tag along with the other exist printed request parameters. Are you aware that there are two tag fields in struct request, namely "tag" and "internal_tag"? Are you aware that how these fields are used depends on whether or not a scheduler is attached to a request queue? Have you verified that the "tag" field contains a meaningful value for blk-mq for every blk-mq tracepoint? Thanks, Bart.
Powered by blists - more mailing lists