linux-kernel - Re: [PATCH] soc: qcom: cmd-db: Make endian-agnostic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 00:08:27 +0000
From:   Evan Green <evgreen@...omium.org>
To:     swboyd@...omium.org
Cc:     Andy Gross <andy.gross@...aro.org>, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        msivasub@...eaurora.org, Lina Iyer <ilina@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: Make endian-agnostic

On Thu, Apr 12, 2018 at 3:41 PM Stephen Boyd <swboyd@...omium.org> wrote:

> This driver deals with memory that is stored in little-endian format.
> Update the structures with the proper little-endian types and then
> do the proper conversions when reading the fields. Note that we compare
> the ids with a memcmp() because we already pad out the string 'id' field
> to exactly 8 bytes with the strncpy() onto the stack.

> Cc: Mahesh Sivasubramanian <msivasub@...eaurora.org>
> Cc: Lina Iyer <ilina@...eaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Evan Green <evgreen@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---

> Changes from inline patch:
>   * Fixed magic
>   * Made function for memcmp()
>   *

>   drivers/soc/qcom/cmd-db.c | 116 +++++++++++++++++++++-----------------
>   1 file changed, 65 insertions(+), 51 deletions(-)

> Sent by a computer through tubes


Reviewed-by: Evan Green <evgreen@...omium.org>