linux-kernel - Re: [PATCH] regulator: Fix return type of of_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180417172229.GK8973@sirena.org.uk>
Date:   Tue, 17 Apr 2018 18:22:29 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     David Collins <collinsd@...eaurora.org>, evgreen@...omium.org,
        swboyd@...omium.org,
        Javier Martinez Canillas <javier@...hile0.org>,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org
Subject: Re: [PATCH] regulator: Fix return type of of_map_mode()

On Tue, Apr 17, 2018 at 10:12:04AM -0700, Douglas Anderson wrote:
> In of_get_regulation_constraints() it can clearly be seen that the
> return value of of_map_mode() is assigned to a signed integer.  This
> is important because the first thing the regulator core does with this
> value is to compare it to -EINVAL.
> 
> Let's fix the return type of all of the current of_map_mode()
> functions.  While we're at it, we'll remove one pointless "inline".

Ah, I see...  the thing here is that the mode is always an unsigned int
since it's a bitmask - this goes out beying the use in of_map_mode() and
into all the other APIs.  We only actually use 4 bits currently so I
think there's no problem switching to int but it seems we should
probably do that consistently throughout the API so that things don't
get missed later on.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)