[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <10e422dd-a3ca-8ecb-50fa-e7f131a55a12@amd.com>
Date: Tue, 17 Apr 2018 13:36:33 -0400
From: "Hook, Gary" <ghook@....com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>,
"gary.hook@....com" <gary.hook@....com>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] iommu - Enable debugfs exposure of the IOMMU
On 4/13/2018 7:55 PM, Mehta, Sohil wrote:
> On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote:
>>
>>
>> +struct dentry *iommu_debugfs_setup(void)
>> +{
>> + if (!debugfs_initialized())
>
> This check is probably not needed.
Ah, so it isn't. Thank you.
>
>> + return NULL;
>> +
>> + if (!iommu_debugfs_dir)
>> + iommu_debugfs_dir = debugfs_create_dir("iommu",
>> NULL);
>> +
>> + if (iommu_debugfs_dir)
>> + pr_warn("WARNING: IOMMU DEBUGFS SUPPORT HAS BEEN
>> ENABLED IN THIS KERNEL\n");
>> +
>
> As this gets called for each IOMMU, do you want to use pr_warn_once?
That works, yes.
>
>> + return iommu_debugfs_dir;
>> +}
>> +EXPORT_SYMBOL_GPL(iommu_debugfs_setup);
>
> -Sohil
>
Powered by blists - more mailing lists