[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e676fae-6c96-08a5-d27a-478d91416cb4@gmail.com>
Date: Tue, 17 Apr 2018 11:18:49 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: vicentiu.galanopulo@....com, andrew@...n.ch, robh@...nel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
mark.rutland@....com, davem@...emloft.net, marcel@...tmann.org,
devicetree@...r.kernel.org
Cc: alexandru.marginean@....com, madalin.bucur@....com
Subject: Re: [PATCH net-next 2/3] net: phy: Change the array size to 32 for
device_ids
On 04/17/2018 02:02 AM, Vicentiu Galanopulo wrote:
> In the context of enabling the discovery of the PHYs
> which have the C45 MDIO address space in a non-standard
> address: num_ids in get_phy_c45_ids, has the
> value 8 (ARRAY_SIZE(c45_ids->device_ids)), but the
> u32 *devs can store 32 devices in the bitfield.
>
> If a device is stored in *devs, in bits 32 to 9
> (bit counting in lookup loop starts from 1), it will
> not be found.
>
> Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@....com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists