linux-kernel - Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <68ec9aff-b523-dd30-cd73-42dc8c792ba1@au1.ibm.com>
Date:   Tue, 17 Apr 2018 14:09:41 +1000
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     "Alastair D'Silva" <alastair@....ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        mikey@...ling.org, vaibhav@...ux.vnet.ibm.com,
        aneesh.kumar@...ux.vnet.ibm.com, malat@...ian.org,
        felix@...ux.vnet.ibm.com, pombredanne@...b.com,
        sukadev@...ux.vnet.ibm.com, npiggin@...il.com,
        gregkh@...uxfoundation.org, arnd@...db.de,
        fbarrat@...ux.vnet.ibm.com, corbet@....net,
        "Alastair D'Silva" <alastair@...ilva.org>
Subject: Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9

On 17/04/18 12:09, Alastair D'Silva wrote:
> diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h
> index be8c9fa23983..5b03d8a82409 100644
> --- a/arch/powerpc/include/asm/switch_to.h
> +++ b/arch/powerpc/include/asm/switch_to.h
> @@ -94,6 +94,5 @@ static inline void clear_task_ebb(struct task_struct *t)
>   extern int set_thread_uses_vas(void);
>   
>   extern int set_thread_tidr(struct task_struct *t);
> -extern void clear_thread_tidr(struct task_struct *t);

This hunk looks like it really belongs in patch 3.

Apart from that, I'm not really familiar with the CPU features code but 
nothing seems overly wrong...

Reviewed-by: Andrew Donnellan <andrew.donnellan@....ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited