linux-kernel - [PATCH] platform/x86: dell-smbios: Match on www.dell.com in OEM strings too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1523994356-9598-1-git-send-email-mario.limonciello@dell.com>
Date:   Tue, 17 Apr 2018 14:45:56 -0500
From:   Mario Limonciello <mario.limonciello@...l.com>
To:     dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Mario Limonciello <mario.limonciello@...l.com>
Subject: [PATCH] platform/x86: dell-smbios: Match on www.dell.com in OEM strings too

Sergey reported that some much older Dell systems don't support
the OEM string "Dell System" but instead supported www.dell.com
in OEM strings.

Match both of these to indicate that this driver is running on
a Dell system.

Reported-by: Sergey Kubushyn <ksi@...8.net>
Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>
Tested-by: Sergey Kubushyn <ksi@...8.net>
---
 drivers/platform/x86/dell-smbios-base.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 2485c80..fbd6557 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -555,11 +555,15 @@ static void free_group(struct platform_device *pdev)
 
 static int __init dell_smbios_init(void)
 {
-	const struct dmi_device *valid;
+	const struct dmi_device *valid_dell_system;
+	const struct dmi_device *valid_www;
 	int ret, wmi, smm;
 
-	valid = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL);
-	if (!valid) {
+	valid_dell_system =
+		dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL);
+	valid_www =
+		dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL);
+	if (!valid_dell_system && !valid_www) {
 		pr_err("Unable to run on non-Dell system\n");
 		return -ENODEV;
 	}
-- 
2.7.4