linux-kernel - Re: [PATCH] MIPS: dts: avoid unneeded built-in.a creation in vendor DTS directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 22:37:36 +0100
From:   James Hogan <jhogan@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
        Paul Cercueil <paul@...pouillou.net>,
        devicetree@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Mathieu Malaterre <malat@...ian.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Harvey Hunt <harvey.hunt@...tec.com>
Subject: Re: [PATCH] MIPS: dts: avoid unneeded built-in.a creation in vendor
 DTS directories

On Tue, Apr 17, 2018 at 12:41:30AM +0900, Masahiro Yamada wrote:
> arch/mips/boot/dts/Makefile collects objects from sub-directories
> into built-in.a only when CONFIG_BUILTIN_DTB is enabled.  Reflect
> it also to the sub-directory Makefiles.  This suppresses unneeded
> built-in.a creation in arch/mips/boot/dts/*/ directories.
> 
> While I am here, I replaced $(patsubst %.dtb, %.dtb.o, $(dtb-y))
> with $(addsuffix .o, $(dtb-y)) to simplify the code a little bit.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  arch/mips/boot/dts/brcm/Makefile          | 2 +-
>  arch/mips/boot/dts/cavium-octeon/Makefile | 2 +-
>  arch/mips/boot/dts/ingenic/Makefile       | 2 +-
>  arch/mips/boot/dts/lantiq/Makefile        | 2 +-
>  arch/mips/boot/dts/mscc/Makefile          | 2 +-
>  arch/mips/boot/dts/mti/Makefile           | 2 +-
>  arch/mips/boot/dts/netlogic/Makefile      | 2 +-
>  arch/mips/boot/dts/pic32/Makefile         | 2 +-
>  arch/mips/boot/dts/ralink/Makefile        | 2 +-
>  arch/mips/boot/dts/xilfpga/Makefile       | 2 +-
>  10 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/brcm/Makefile b/arch/mips/boot/dts/brcm/Makefile
> index d8787c9..d85f446 100644
> --- a/arch/mips/boot/dts/brcm/Makefile
> +++ b/arch/mips/boot/dts/brcm/Makefile
> @@ -34,4 +34,4 @@ dtb-$(CONFIG_DT_NONE) += \
>  	bcm97425svmb.dtb \
>  	bcm97435svmb.dtb
>  
> -obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
> +obj-$(CONFIG_BUILTIN_DTB)	+= $(addsuffix .o, $(dtb-y))

I like this. I had also spotted the .o files being unnecessarily
generated when building the dtbs target with bmips and CONFIG_DT_NONE=y.
I'll apply for 4.18.

Thanks
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)