linux-kernel - Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r2ndijxa.fsf@anholt.net>
Date:   Tue, 17 Apr 2018 14:48:17 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Mark Rutland <mark.rutland@....com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Florian Fainelli <f.fainelli@...il.com>,
        "moderated list\:ARM\/FREESCALE IMX \/ MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, Stefan Wahren <stefan.wahren@...e.com>,
        "moderated list\:BROADCOM BCM2835 ARM ARCHITECTURE" 
        <linux-rpi-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/3] drm/vc4: Remove the need for the GPU-subsystem DT node.

Rob Herring <robh+dt@...nel.org> writes:

> On Mon, Apr 16, 2018 at 5:52 PM, Eric Anholt <eric@...olt.net> wrote:
>> The GPU subsystem node was a workaround to have a central device to
>> bind V3D and display to.  Following the lead of 246774d17fc0
>> ("drm/etnaviv: remove the need for a gpu-subsystem DT node"), remove
>> the subsystem node usage and just create a platform device for the DRM
>> device to attach to if any of the subsystem devices are present.
>>
>> v2: Simplify the DT walking code.
>> v3: Always put the node.
>>
>> Signed-off-by: Eric Anholt <eric@...olt.net>
>> ---
>>  .../bindings/display/brcm,bcm-vc4.txt         |  7 -----
>>  drivers/gpu/drm/vc4/vc4_drv.c                 | 28 +++++++++++++------
>>  drivers/gpu/drm/vc4/vc4_hvs.c                 |  1 +
>>  drivers/gpu/drm/vc4/vc4_v3d.c                 |  1 +
>>  4 files changed, 22 insertions(+), 15 deletions(-)
>
> Reviewed-by: Rob Herring <robh@...nel.org>

Unfortunately, on further testing, this ends up broken.  My guess is
that our new platform device isn't on the same bus, so we don't get our
dma-ranges translation when we use drm->dev, and that breaks caching
behavior.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)