linux-kernel - Re: [PATCH] infiniband: mlx5: fix build error when INFINIBAND_USER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Apr 2018 18:49:37 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jason Gunthorpe <jgg@...lanox.com>
Cc:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH] infiniband: mlx5: fix build error when
 INFINIBAND_USER_ACCESS=m

On 04/16/18 14:55, Jason Gunthorpe wrote:
> On Mon, Apr 16, 2018 at 02:21:07PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build errors when INFINIBAND_USER_ACCESS=m and MLX5_INFINIBAND=y.
>> The build error occurs when the mlx5 driver code attempts to use
>> USER_ACCESS interfaces, which are built as a loadable module.
>>
>> Fixes these build errors:
>>
>> drivers/infiniband/hw/mlx5/main.o: In function `populate_specs_root':
>> ../drivers/infiniband/hw/mlx5/main.c:4982: undefined reference to `uverbs_default_get_objects'
>> ../drivers/infiniband/hw/mlx5/main.c:4994: undefined reference to `uverbs_alloc_spec_tree'
>> drivers/infiniband/hw/mlx5/main.o: In function `depopulate_specs_root':
>> ../drivers/infiniband/hw/mlx5/main.c:5001: undefined reference to `uverbs_free_spec_tree'
>>
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Matan Barak <matanb@...lanox.com>
>> Cc: Jason Gunthorpe <jgg@...lanox.com>
>> Cc: Leon Romanovsky <leonro@...lanox.com>
>> Cc: Doug Ledford <dledford@...hat.com>
>> Cc: linux-rdma@...r.kernel.org
>> Cc: stable@...r.kernel.org # reported against 4.16
>>  drivers/infiniband/hw/mlx5/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> +++ lnx-417-rc1/drivers/infiniband/hw/mlx5/Kconfig
>> @@ -1,6 +1,7 @@
>>  config MLX5_INFINIBAND
>>  	tristate "Mellanox Connect-IB HCA support"
>>  	depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
>> +	select INFINIBAND_USER_ACCESS
> 
> Shouldn't this be done via
> 
> 	depends on m || INFINIBAND_USER_ACCESS != m
> 
> ?
> 
> We can turn off USER_ACCESS and still successfully compile the driver.

Argh, thanks, I didn't notice that.  v2 on the way but not quite the way
that you mentioned, more like it's done in other (netdev) places.

-- 
~Randy