linux-kernel - Re: [PATCH 6/6] cifs: smbd: Dump SMB packet when configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180417072954.GE15310@kroah.com>
Date:   Tue, 17 Apr 2018 09:29:54 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     longli@...rosoft.com
Cc:     Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 6/6] cifs: smbd: Dump SMB packet when configured

On Mon, Apr 16, 2018 at 05:49:18PM -0700, Long Li wrote:
> From: Long Li <longli@...rosoft.com>
> 
> When sending through SMB Direct, also dump the packet in SMB send path.
> 
> Also fixed a typo in debug message.
> 
> Signed-off-by: Long Li <longli@...rosoft.com>
> ---
>  fs/cifs/smbdirect.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
> index f575e9a..6ff864a 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -1029,7 +1029,7 @@ static int smbd_post_send(struct smbd_connection *info,
>  	for (i = 0; i < request->num_sge; i++) {
>  		log_rdma_send(INFO,
>  			"rdma_request sge[%d] addr=%llu length=%u\n",
> -			i, request->sge[0].addr, request->sge[0].length);
> +			i, request->sge[i].addr, request->sge[i].length);
>  		ib_dma_sync_single_for_device(
>  			info->id->device,
>  			request->sge[i].addr,
> @@ -2130,6 +2130,10 @@ int smbd_send(struct smbd_connection *info, struct smb_rqst *rqst)
>  		goto done;
>  	}
>  
> +	cifs_dbg(FYI, "Sending smb (RDMA): smb_len=%u\n", buflen);
> +	for (i = 0; i < rqst->rq_nvec-1; i++)
> +		dump_smb(iov[i].iov_base, iov[i].iov_len);
> +
>  	remaining_data_length = buflen;
>  
>  	log_write(INFO, "rqst->rq_nvec=%d rqst->rq_npages=%d rq_pagesz=%d "
> -- 
> 2.7.4

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>