[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56bdafe6-1725-6e55-68a4-38667f114e5c@ti.com>
Date: Tue, 17 Apr 2018 14:49:37 +0530
From: Kishon Vijay Abraham I <kishon@...com>
To: Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
<bhelgaas@...gle.com>, <lorenzo.pieralisi@....com>,
<Joao.Pinto@...opsys.com>, <jingoohan1@...il.com>,
<robh+dt@...nel.org>, <mark.rutland@....com>
CC: <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 03/10] PCI: endpoint: functions/pci-epf-test: Add
second entry
Hi,
On Monday 16 April 2018 08:07 PM, Gustavo Pimentel wrote:
> Adds a seconds entry on the pci_epf_test_ids structure that disables the
> linkup_notifier parameter on driver.
>
> This allows EPs that doesn't have linkup notification signal to work
> with pcitest.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> ---
> Change v2->v3:
> - Added second entry in pci_epf_test_ids structure.
> - Remove test_reg_bar field assignment on second entry.
> Changes v3->v4:
> - Nothing changed, just to follow the patch set version.
>
> drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 7cef851..63dca44 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf)
> return 0;
> }
>
> +static const struct pci_epf_test_data data_cfg2 = {
> + .linkup_notifier = false
> +};
> +
> static const struct pci_epf_device_id pci_epf_test_ids[] = {
> {
> .name = "pci_epf_test",
> },
> + {
> + .name = "pci_epf_test_cfg2",
I'd prefer this to be named pci_epf_test_designware so that configfs entry is
self explanatory.
Thanks
Kishon
Powered by blists - more mailing lists