linux-kernel - Re: [PATCH] x86/tsc: fix 64bit divisor be truncated in calc_hpet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1804171121450.1694@nanos.tec.linutronix.de>
Date:   Tue, 17 Apr 2018 11:24:34 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Xiaoming Gao <gxm.linux.kernel@...il.com>
cc:     x86@...nel.org, linux-kernel@...r.kernel.org, mingo@...hat.com,
        peterz@...radead.org, hpa@...or.com
Subject: Re: [PATCH] x86/tsc: fix 64bit divisor be truncated in
 calc_hpet_ref

On Fri, 13 Apr 2018, Xiaoming Gao wrote:
> From ba3d2fb699c4d8ee61b05d7e70be48b9c4e22baf Mon Sep 17 00:00:00 2001
> From: Xiaoming Gao <newtongao@...cent.com>
> Date: Fri, 13 Apr 2018 17:05:18 +0800
> Subject: [PATCH] x86/tsc: fix 64bit divisor be truncated in calc_hpet_ref
> 
> the HPET frequency got larger on intel skylake, thus could cause tmp to
> exceed 32bits.
> do_div will truncate 64bits tmp to 32bits, so the frequency calced via
> HPET will be wrong, use div64_u64 can fix it.
> 
> Signed-off-by: Xiaoming Gao <newtongao@...cent.com>
> ---
>  arch/x86/kernel/tsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 9714a7a..8700269 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -160,7 +160,7 @@ static unsigned long calc_hpet_ref(u64 deltatsc, u64
> hpet1, u64 hpet2)
>      hpet2 -= hpet1;
>      tmp = ((u64)hpet2 * hpet_readl(HPET_PERIOD));
>      do_div(tmp, 1000000);
> -    do_div(deltatsc, tmp);
> +    deltatsc = div64_u64(deltatsc, tmp);
> 
>      return (unsigned long) deltatsc;

Please fix your MUA so it does not whitespace damage
patches. Documentation/process/email-clients.rst tells you how to teach
thunderbird to do the right thing.

Attaching the patch does not help either as it breaks the workflow. I've
fixed it up manually this time, but please be more careful next time.

Thanks,

	tglx