[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGb2v67qvk=T7u7bOjVZ7q_qsjJuEOM6iarw7by42ga=EYuYDg@mail.gmail.com>
Date: Tue, 17 Apr 2018 19:25:15 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Maxime Ripard <maxime.ripard@...tlin.com>
Cc: Mylène Josserand <mylene.josserand@...tlin.com>,
Russell King <linux@...linux.org.uk>,
Marc Zyngier <marc.zyngier@....com>,
Mark Rutland <mark.rutland@....com>,
Rob Herring <robh+dt@...nel.org>, Simon <horms@...ge.net.au>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Magnus Damm <magnus.damm@...il.com>,
"open list:ARM/SHMOBILE ARM..." <linux-renesas-soc@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
LABBE Corentin <clabbe.montjoie@...il.com>,
Quentin Schulz <quentin.schulz@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 01/11] ARM: sunxi: smp: Move assembly code into a file
On Tue, Apr 17, 2018 at 7:17 PM, Maxime Ripard
<maxime.ripard@...tlin.com> wrote:
> On Tue, Apr 17, 2018 at 11:12:41AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Apr 17, 2018 at 5:50 AM, Mylène Josserand
>> <mylene.josserand@...tlin.com> wrote:
>> > Move the assembly code for cluster cache enabling and resuming
>> > into an assembly file instead of having it directly in C code.
>> >
>> > Remove the CFLAGS because we are using the ARM directive "arch"
>> > instead.
>> >
>> > Signed-off-by: Mylène Josserand <mylene.josserand@...tlin.com>
>> > ---
>> > arch/arm/mach-sunxi/Makefile | 4 +--
>> > arch/arm/mach-sunxi/headsmp.S | 80 +++++++++++++++++++++++++++++++++++++++++
>> > arch/arm/mach-sunxi/mc_smp.c | 82 +++----------------------------------------
>> > 3 files changed, 85 insertions(+), 81 deletions(-)
>> > create mode 100644 arch/arm/mach-sunxi/headsmp.S
>>
>> I'm still not convinced about this whole "move ASM to separate
>> file" thing, especially now that you aren't actually adding any
>> sunxi-specific ASM code beyond a simple function call.
>>
>> Could you drop this for now?
>
> I'd really like to have this merged actually. There's a significant
> readibility improvement, so even if there's no particular functional
> improvement, I'd still call it a win.
What parts do you consider hard to read? The extra quotes? Trailing
newline? Or perhaps the __stringify bits?
ChenYu
Powered by blists - more mailing lists