linux-kernel - Re: [PATCH net-next 2/3] net: phy: Change the array size to 32 for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180417125429.GE2591@lunn.ch>
Date:   Tue, 17 Apr 2018 14:54:29 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vicentiu Galanopulo <vicentiu.galanopulo@....com>
Cc:     robh@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        davem@...emloft.net, marcel@...tmann.org,
        devicetree@...r.kernel.org, alexandru.marginean@....com,
        madalin.bucur@....com
Subject: Re: [PATCH net-next 2/3] net: phy: Change the array size to 32 for
 device_ids

On Tue, Apr 17, 2018 at 04:02:32AM -0500, Vicentiu Galanopulo wrote:
> In the context of enabling the discovery of the PHYs
> which have the C45 MDIO address space in a non-standard
> address:  num_ids in get_phy_c45_ids, has the
> value 8 (ARRAY_SIZE(c45_ids->device_ids)), but the
> u32 *devs can store 32 devices in the bitfield.
> 
> If a device is stored in *devs, in bits 32 to 9
> (bit counting in lookup loop starts from 1), it will
> not be found.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew