linux-kernel - Re: [PATCH] hsi: clients: Change return type to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180417140737.45xtk7qanthxzgsm@earth.universe>
Date:   Tue, 17 Apr 2018 16:07:37 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     viro@...iv.linux.org.uk, arnd@...db.de,
        linux-kernel@...r.kernel.org, willy@...radead.org
Subject: Re: [PATCH] hsi: clients: Change return type to vm_fault_t

Hi,

On Tue, Apr 17, 2018 at 07:27:42PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Reference id -> 1c8f422059ae ("mm: change return type to
> vm_fault_t")
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
>  drivers/hsi/clients/cmt_speech.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 324cb8e..a1d4b93 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -1098,7 +1098,7 @@ static void cs_hsi_stop(struct cs_hsi_iface *hi)
>  	kfree(hi);
>  }
> 
> -static int cs_char_vma_fault(struct vm_fault *vmf)
> +static vm_fault_t cs_char_vma_fault(struct vm_fault *vmf)
>  {
>  	struct cs_char *csdata = vmf->vma->vm_private_data;
>  	struct page *page;
> --
> 1.9.1
> 

Thanks, queued to hsi-next.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)