linux-kernel - Re: [PATCH v4 02/15] KVM: s390: reset crypto attributes for all vcpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4dd8242a-4f25-065f-5eea-e53c73130763@linux.vnet.ibm.com>
Date:   Tue, 17 Apr 2018 10:55:30 -0400
From:   Tony Krowiak <akrowiak@...ux.vnet.ibm.com>
To:     Halil Pasic <pasic@...ux.vnet.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        akrowiak@...ux.vnet.ibm.com
Cc:     freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, borntraeger@...ibm.com,
        cohuck@...hat.com, kwankhede@...dia.com,
        bjsdjshi@...ux.vnet.ibm.com, pbonzini@...hat.com,
        alex.williamson@...hat.com, pmorel@...ux.vnet.ibm.com,
        alifm@...ux.vnet.ibm.com, mjrosato@...ux.vnet.ibm.com,
        jjherne@...ux.vnet.ibm.com, thuth@...hat.com, berrange@...hat.com,
        fiuczy@...ux.vnet.ibm.com, buendgen@...ibm.com
Subject: Re: [PATCH v4 02/15] KVM: s390: reset crypto attributes for all vcpus

On 04/17/2018 10:29 AM, Halil Pasic wrote:
>
>
> On 04/15/2018 11:22 PM, Tony Krowiak wrote:
>> Introduces a new function to reset the crypto attributes for all
>> vcpus whether they are running or not. Each vcpu in KVM will
>> be removed from SIE prior to resetting the crypto attributes in its
>> SIE state description. After all vcpus have had their crypto attributes
>> reset the vcpus will be restored to SIE.
>>
>> This function will be used in a later patch to set the ECA.28
>> bit in the SIE state description to enable interpretive execution of
>> AP instructions. It will also be incorporated into the
>> kvm_s390_vm_set_crypto(kvm) function to fix an issue whereby the crypto
>> key wrapping attributes could potentially get out of synch for running
>> vcpus.
>>
>
> Wasn't this 'issue' reported by me by any chance?

Yes it was .... was I supposed to include that fact in the commit message?

>
> I agree with Connnie, we don't need the forward reference to
> ECA.28.

I'm not sure that's exactly what she said, but I'd be more than happy
to remove it.

>
>
> Regards,
> Halil
>
>> Signed-off-by: Tony Krowiak<akrowiak@...ux.vnet.ibm.com>
>