linux-kernel - Re: [PATCH v3] module: Fix display of wrong module .text address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180418071724.GA6892@eros>
Date:   Wed, 18 Apr 2018 17:17:24 +1000
From:   "Tobin C. Harding" <me@...in.cc>
To:     Thomas Richter <tmricht@...ux.ibm.com>
Cc:     jeyu@...nel.org, torvalds@...ux-foundation.org,
        linux-kernel@...r.kernel.org, borntraeger@...ibm.com,
        schwidefsky@...ibm.com, brueckner@...ux.vnet.ibm.com,
        heiko.carstens@...ibm.com, peterz@...radead.org, acme@...nel.org,
        keescook@...omium.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] module: Fix display of wrong  module .text address

On Wed, Apr 18, 2018 at 09:14:36AM +0200, Thomas Richter wrote:
> Reading file /proc/modules shows the correct address:
> [root@...lp76 ~]# cat /proc/modules | egrep '^qeth_l2'
> qeth_l2 94208 1 - Live 0x000003ff80401000
> 
> and reading file /sys/module/qeth_l2/sections/.text
> [root@...lp76 ~]# cat /sys/module/qeth_l2/sections/.text
> 0x0000000018ea8363
> displays a random address.
> 
> This breaks the perf tool which uses this address on s390
> to calculate start of .text section in memory.
> 
> Fix this by printing the correct (unhashed) address.
> 
> Thanks to Jessica Yu for helping on this.
> 
> Fixes: ef0010a30935 ("vsprintf: don't use 'restricted_pointer()' when not restricting")
> Cc: <stable@...r.kernel.org> # v4.15+
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> Cc: Jessica Yu <jeyu@...nel.org>
> ---

What's changed in each version please?


thanks,
Tobin.