linux-kernel - Re: [PATCH] Revert "ata: ahci-platform: add reset control support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180418083647.GA5503@ulmo>
Date:   Wed, 18 Apr 2018 10:36:47 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org
Cc:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Hans de Goede <hdegoede@...hat.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "ata: ahci-platform: add reset control support"

On Mon, Apr 09, 2018 at 09:02:33AM +0200, Hans de Goede wrote:
> HI,
> 
> On 09-04-18 03:32, Kunihiko Hayashi wrote:
> > This reverts commit f0f56716fc3e5d547fd7811eb218a30ed0695605.
> > 
> > According to Thierry's view,
> > https://www.spinics.net/lists/linux-ide/msg55357.html
> > some hardware-specific drivers already use their own resets,
> > and the common reset might make a path to occur double controls of resets.
> > 
> > For now, revert the commit that adds reset control support to ahci-platform,
> > and hold until the solution is confirmed not be affect all hardware-specific
> > drivers.
> > 
> > Fixes: f0f56716fc3e ("ata: ahci-platform: add reset control support")
> > Reported-by: Thierry Reding <thierry.reding@...il.com>
> > Suggested-by: Hans de Goede <hdegoede@...hat.com>
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> 
> Acked-by: Hans de Goede <hdegoede@...hat.com>

Hi Tejun,

I see that you've applied this to your for-next branch. However, this is
a fix that needs to go into v4.17 because that's where the regression
was introduced. Is there any way you can promote this to a fixes branch?

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)