linux-kernel - Re: [PATCH] nvme: fix the suspicious RCU usage warning in nvme_mpath_clear_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180418150710.GB7862@lst.de>
Date:   Wed, 18 Apr 2018 17:07:10 +0200
From:   Christoph Hellwig <hch@....de>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Jianchao Wang <jianchao.w.wang@...cle.com>, axboe@...com,
        hch@....de, sagi@...mberg.me, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: fix the suspicious RCU usage warning in
        nvme_mpath_clear_current_path

On Wed, Apr 18, 2018 at 08:45:25AM -0600, Keith Busch wrote:
> Nothing against this patch. This just doesn't look correct even from
> before since nvme_find_path can set head->current_path right back to
> this namespace that we're trying to clear.
> 
> Christoph, am I missing something here or does this need additional
> checks/synchronization?

Yes, we should probably call it after removing the namespace from
the ns_head list, instead of right before.