linux-kernel - Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a44ead3d-8565-2d44-5a28-dfc51d4920d9@oracle.com>
Date:   Wed, 18 Apr 2018 14:03:37 -0600
From:   Tom Hromatka <tom.hromatka@...cle.com>
To:     Shuah Khan <shuah@...nel.org>, davem@...emloft.net
Cc:     sparclinux@...r.kernel.org, arnd@...db.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, allen.pais@...cle.com,
        khalid.aziz@...cle.com, shannon.nelson@...cle.com,
        anthony.yznaga@...cle.com, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 2/2] selftests: sparc64: char: Selftest for privileged ADI
 driver



On 04/18/2018 01:58 PM, Shuah Khan wrote:
> Hi Tom,
>
> On 04/18/2018 10:29 AM, Tom Hromatka wrote:
>> Add a selftest for the sparc64 privileged ADI driver.  These
>> tests verify the read(), pread(), write(), pwrite(), and seek()
>> functionality of the driver.  The tests also report simple
>> performance statistics:
>>
>>          Syscall Call    AvgTime AvgSize
>>                  Count   (ticks) (bytes)
>>          -------------------------------
>>          read          3  167134    8133
>>          pread         4  137217    6741
>>          write         3   73787    8133
>>          pwrite        4   65832    6741
>>          seek         10    2422       0
>>
>>          Ran 8 tests
>>          All tests passed
>>
>> Signed-off-by: Tom Hromatka <tom.hromatka@...cle.com>
>> Reviewed-by: Allen Pais <allen.pais@...cle.com>
> Thanks for the patch. A few comments below:

Thanks for the quick turnaround, Shuah.  I'll work through your
comments and get a v2 out in the next few days.

Regards.

Tom