linux-kernel - Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22cf611b-6a88-ec72-bb3c-51f8b62a8019@linux.intel.com>
Date:   Wed, 18 Apr 2018 09:04:48 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, linux-spi@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be
 static

On 04/17/18 22:53, kbuild test robot wrote:
> 
> Fixes: d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop")
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>   spi-pxa2xx.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index c852ea5..40f1346 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master,
>   	       xfer->len >= chip->dma_burst_size;
>   }
>   
> -int pxa2xx_spi_transfer_one(struct spi_controller *master,
> -			    struct spi_device *spi,
> -			    struct spi_transfer *transfer)
> +static int pxa2xx_spi_transfer_one(struct spi_controller *master,
> +				   struct spi_device *spi,
> +				   struct spi_transfer *transfer)

Thanks Fengguang. I don't understand how I managed to drop "static" 
while doing manual s/pump_transfers/pxa2xx_spi_transfer_one/ :-)

Reviewed-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>