linux-kernel - Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180419074645.p47cevwpzwwak3sk@pali>
Date:   Thu, 19 Apr 2018 09:46:45 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     mjg59@...f.ucam.org, dvhart@...radead.org, andy@...radead.org,
        mario.limonciello@...l.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new rfkill and fn-lock
 events

On Thursday 19 April 2018 15:24:49 Kai-Heng Feng wrote:
> There are two new events generated by dell-wmi, rfkill and fn-lock, from
> Dell Systems.
> 
> These events are for notification purpose, so we can ignore them.
> 
> Tested on XPS 9370.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> I ordered them functionally instead of alphabetically, I can re-order
> them to alphabetically if that's more diserable.

Please order them by event code like they were prior your change.

>  drivers/platform/x86/dell-wmi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 8d102195a392..51d2845d2ad9 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -266,6 +266,13 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  
>  	/* Fn-lock */
>  	{ KE_IGNORE, 0x151, { KEY_RESERVED } },
> +	{ KE_IGNORE, 0xe035, { KEY_RESERVED } },
> +
> +	/* Fn-lock switched to function keys */
> +	{ KE_IGNORE, 0x0000, { KEY_RESERVED } },
> +
> +	/* Fn-lock switched to multimedia keys */
> +	{ KE_IGNORE, 0x0001, { KEY_RESERVED } },

Are you sure that all those codes are not defined in 0xB2 DMI hotkey
table? Also is Fn-lock key reported by PS/2 AT Keyboard controller so it
is needed to ignored it by WMI?

>  	/* Change keyboard illumination */
>  	{ KE_IGNORE, 0x152, { KEY_KBDILLUMTOGGLE } },
> @@ -275,6 +282,7 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	 * WMI event is supposed to trigger an action).
>  	 */
>  	{ KE_IGNORE, 0x153, { KEY_RFKILL } },
> +	{ KE_IGNORE, 0xe008, { KEY_RFKILL } },
>  
>  	/* RGB keyboard backlight control */
>  	{ KE_IGNORE, 0x154, { KEY_RESERVED } },

-- 
Pali Rohár
pali.rohar@...il.com