linux-kernel - Re: [PATCH] USB: Increment wakeup count on remote wakeup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201804191703.j9cCt1T7%fengguang.wu@intel.com>
Date:   Thu, 19 Apr 2018 17:33:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ravi Chandra Sadineni <ravisadineni@...omium.org>
Cc:     kbuild-all@...org, stern@...land.harvard.edu,
        gregkh@...uxfoundation.org, martin.blumenstingl@...glemail.com,
        ravisadineni@...gle.com, chunfeng.yun@...iatek.com,
        johan@...nel.org, arvind.yadav.cs@...il.com, dtor@...gle.com,
        anton.bondarenko.sama@...il.com, f.fainelli@...il.com,
        keescook@...omium.org, mathias.nyman@...ux.intel.com,
        felipe.balbi@...ux.intel.com, ekorenevsky@...il.com,
        peter.chen@....com, joe@...ches.com, tbroch@...gle.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        rajatja@...gle.com, bleung@...gle.com,
        Ravi Chandra Sadineni <ravisadineni@...omium.org>
Subject: Re: [PATCH] USB: Increment wakeup count on remote wakeup.

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-s0-201815 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb/core/hcd.c:2378:18: error: 'dev' undeclared (first use in this function)
     pm_wakeup_event(dev, 0);
                     ^~~
   drivers/usb/core/hcd.c:2378:18: note: each undeclared identifier is reported only once for each function it appears in

vim +/dev +2378 drivers/usb/core/hcd.c

  2364	
  2365	/**
  2366	 * usb_hcd_resume_root_hub - called by HCD to resume its root hub
  2367	 * @hcd: host controller for this root hub
  2368	 *
  2369	 * The USB host controller calls this function when its root hub is
  2370	 * suspended (with the remote wakeup feature enabled) and a remote
  2371	 * wakeup request is received.  The routine submits a workqueue request
  2372	 * to resume the root hub (that is, manage its downstream ports again).
  2373	 */
  2374	void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
  2375	{
  2376		unsigned long flags;
  2377	
> 2378		pm_wakeup_event(dev, 0);
  2379		spin_lock_irqsave (&hcd_root_hub_lock, flags);
  2380		if (hcd->rh_registered) {
  2381			set_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags);
  2382			queue_work(pm_wq, &hcd->wakeup_work);
  2383		}
  2384		spin_unlock_irqrestore (&hcd_root_hub_lock, flags);
  2385	}
  2386	EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
  2387	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31325 bytes)