linux-kernel - Re: Some questions about cgroup aware OOM killer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180419104336.GA20675@castle.DHCP.thefacebook.com>
Date:   Thu, 19 Apr 2018 11:43:42 +0100
From:   Roman Gushchin <guro@...com>
To:     ufo19890607 <ufo19890607@...il.com>
CC:     <mhocko@...e.com>, <vdavydov.dev@...il.com>,
        <penguin-kernel@...ove.sakura.ne.jp>, <rientjes@...gle.com>,
        <akpm@...ux-foundation.org>, <tj@...nel.org>, <kernel-team@...com>,
        <cgroups@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>, yuzhoujian <yuzhoujian@...ichuxing.com>
Subject: Re: Some questions about cgroup aware OOM killer.

Hi!

Please, pull the whole patchset from the next tree:
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

$ git log next/master --oneline --author=guro@...com
1fecc970ac9e cgroup: list groupoom in cgroup features
dff73d397f7f mm-oom-docs-describe-the-cgroup-aware-oom-killer-fix
7cf83086511a mm, oom, docs: describe the cgroup-aware OOM killer
e2194b2869f1 mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer
338fbcc52518 mm, oom: return error on access to memory.oom_group if groupoom is disabled
96fb32250ded mm, oom: introduce memory.oom_group
ed5f99985bf8 mm, oom: cgroup-aware OOM killer
e33eba2c3273 mm: implement mem_cgroup_scan_tasks() for the root memory cgroup
9bd3a4c529d4 mm, oom: refactor oom_kill_process()

Thanks!

On Thu, Apr 19, 2018 at 08:17:04AM +0100, ufo19890607 wrote:
> From: yuzhoujian <yuzhoujian@...ichuxing.com>
> 
> Hi Roman
> I've read your patchset about cgroup aware OOM killer, and try
> to merge your patchset to the upstream kernel(v4.17-rc1). But
> I found some functions which in your patch([PATCH v13 3/7] 
> mm, oom: cgroup-aware OOM killer) does not exist in the upstream
> kernel. Which version of the kernel do you patch on? And, do you
> have the latest patchset?
> 
> The faults in PATCH v13 3/7:
> 1. mm/oom_kill.o: In function `out_of_memory':
>    /linux/mm/oom_kill.c:1125: undefined reference to `alloc_pages_before_oomkill'
> 2. mm/oom_kill.c: In function ‘out_of_memory’:
>    mm/oom_kill.c:1125:5: error: ‘struct oom_control’ has no member named ‘page’
>    oc->page = alloc_pages_before_oomkill(oc);
>      ^
> 
> Best wishes
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html