lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15d56b6d-6546-0655-563e-4492982c8d78@ti.com>
Date:   Thu, 19 Apr 2018 17:39:26 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Kevin Hilman <khilman@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 2/2] memory: aemif: add support for board files

On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote:
> @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev)
>  		goto error;
>  	}
>  
> -	/*
> -	 * For every controller device node, there is a cs device node that
> -	 * describe the bus configuration parameters. This functions iterate
> -	 * over these nodes and update the cs data array.
> -	 */
> -	for_each_available_child_of_node(np, child_np) {
> -		ret = of_aemif_parse_abus_config(pdev, child_np);
> -		if (ret < 0)
> -			goto error;
> +	if (np) {
> +		/*
> +		 * For every controller device node, there is a cs device node
> +		 * that describe the bus configuration parameters. This
> +		 * functions iterate over these nodes and update the cs data
> +		 * array.
> +		 */
> +		for_each_available_child_of_node(np, child_np) {
> +			ret = of_aemif_parse_abus_config(pdev, child_np);
> +			if (ret < 0)
> +				goto error;
> +		}
> +	} else if (pdata && pdata->num_abus_data > 0) {
> +		for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) {
> +			aemif->cs_data[i].cs = pdata->abus_data->cs;

Since abus_data is an array, shouldn't it be pdata->abus_data[i].cs ?

Thanks,
Sekhar

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ