linux-kernel - Re: [PATCH] KVM: X86: Extend MAX_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180419150641.5922e7e1.cohuck@redhat.com>
Date:   Thu, 19 Apr 2018 15:06:41 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Wanpeng Li <kernellwp@...il.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Tonny Lu <tonnylu@...cent.com>
Subject: Re: [PATCH] KVM: X86: Extend MAX_IRQ_ROUTES to 4096

On Thu, 19 Apr 2018 05:30:40 -0700
Wanpeng Li <kernellwp@...il.com> wrote:

> From: Wanpeng Li <wanpengli@...cent.com>
> 
> Our virtual machines make use of device assignment by configuring
> 12 NVMe disks for high I/O performance. Each NVMe device has 129 
> MSI-X Table entries:
> Capabilities: [50] MSI-X: Enable+ Count=129 Masked-Vector table: BAR=0 offset=00002000
> The windows virtual machines fail to boot since they will map the number of 
> MSI-table entries that the NVMe hardware reported to the bus to msi routing 
> table, this will exceed the 1024. This patch extends MAX_IRQ_ROUTES to 4096,
> In the future this might be extended if needed.
> 
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Radim Krčmář <rkrcmar@...hat.com>
> Cc: Tonny Lu <tonnylu@...cent.com>
> Signed-off-by: Wanpeng Li <wanpengli@...cent.com>
> Signed-off-by: Tonny Lu <tonnylu@...cent.com>
> ---
>  include/linux/kvm_host.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 6930c63..815ae66 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -1050,7 +1050,7 @@ static inline int mmu_notifier_retry(struct kvm *kvm, unsigned long mmu_seq)
>  #elif defined(CONFIG_ARM64)
>  #define KVM_MAX_IRQ_ROUTES 4096
>  #else
> -#define KVM_MAX_IRQ_ROUTES 1024
> +#define KVM_MAX_IRQ_ROUTES 4096
>  #endif
>  
>  bool kvm_arch_can_set_irq_routing(struct kvm *kvm);

So, this basically means we have 4096 everywhere, no?